Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reader and fit function for longitudinal files #39

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Nov 24, 2023

No description provided.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (bdf5174) 95.48% compared to head (8ade117) 95.46%.

Files Patch % Lines
corsikaio/longitudinal.py 91.83% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   95.48%   95.46%   -0.03%     
==========================================
  Files          20       22       +2     
  Lines         643      727      +84     
==========================================
+ Hits          614      694      +80     
- Misses         29       33       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@orelgueta orelgueta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, but you are missing tests for all the cases in which the input file is wrong (all the ValueErrors raised). Not a big deal, so I approve already.

@maxnoe
Copy link
Member Author

maxnoe commented Nov 27, 2023

Yes, the unhappy paths are a bit hard to test in a meaningful way, since I have not yet encountered any broken longitudinal files.

I can test using some dummy data, but for any meaningful error handling, we need to have people report real-world issues and then add tests for that.

@maxnoe maxnoe merged commit 7bd6fe1 into main Nov 27, 2023
4 of 6 checks passed
@maxnoe maxnoe deleted the add_longitudinal branch November 27, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants